Hello, I tried to compile mousepad but had several warnings, caused of incorrect types. As I didn't know how to "not treat warnings as errors" I modified the sources. The typical warning was: cc1: warnings being treated as errors file.c: In function
Created attachment 508 corrected types Here is the diff. 3 files in total caused warnings. Cheers.
Created attachment 514 mousepad-signedness-fix (In reply to comment #1) > Created an attachment (id=508) [edit] > corrected types > > Here is the diff. 3 files in total caused warnings. I've noticed the same problem and applied similar fixes. But I see your patch is not correct because it brokes const correctness regarding functions: g_strstr_len, g_strsplit. I think data member should be casted to const gchar* type. I attached this patch.
(In reply to comment #2) > I've noticed the same problem and applied similar fixes. > But I see your patch is not correct because it brokes const correctness > regarding functions: g_strstr_len, g_strsplit. I think data member should be > casted to const gchar* type. I attached this patch. > Not really sure that this is necessary. Does you really need to cast on a const? Isn't it that the function behaves like to know "this var is const" and touching it will print warnings inside the function. Furthermore I really believe that g_strsre_len will *never* touch the string :) Cheers.
Werror were disabled in trunk, so it compiles with warnings.